Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.fs.delete does not ... delete a file that was just added ... #35

Closed
binduwavell opened this issue Jun 22, 2015 · 4 comments
Closed
Labels

Comments

@binduwavell
Copy link

In yeoman I copy a template folder structure and then based on some prompts I want to remove some of the files that the template copied. Yes I realize I could filter these files out during the copy or split the template copy into two parts. While either of these would be more efficient it makes the code more complicated.

I added the following step to my generator as a test:

testDeletion: function() {
  this.fs.write("foo", "foo");
  this.fs.delete("foo");
},

When the generator completes it creates foo. Now if I run the generator again, I get a diff message if I accept the change foo is deleted.

I expect that the first time through foo is not saved to the filesystem. And hence the second time through I should not see a diff prompt.

I'm not clear what issue #32 is about, I suspect these are different issues, but I could be wrong. Forgive me if I am :)

@SBoudrias SBoudrias added the bug label Jun 22, 2015
binduwavell added a commit to binduwavell/generator-alfresco that referenced this issue Jun 24, 2015
Discovered a bug in mem-fs-editor:
SBoudrias/mem-fs-editor#35
So putting this to rest for a little while
@SBoudrias
Copy link
Owner

Fixed! Thanks for reporting this issue!

binduwavell added a commit to binduwavell/generator-alfresco that referenced this issue Jul 5, 2015
Discovered a bug in mem-fs-editor:
SBoudrias/mem-fs-editor#35
So putting this to rest for a little while
binduwavell added a commit to binduwavell/generator-alfresco that referenced this issue Jul 11, 2015
Discovered a bug in mem-fs-editor:
SBoudrias/mem-fs-editor#35
Which has now been resolved, by using the latest generator
Perform deletion for repo-amp
Perform deletion for share-amp
@miguelsmuller
Copy link

any news ?

@SBoudrias
Copy link
Owner

@miguelsmuller if you have an issue either open an issue or ask a question on StackOverflow.

There's no point to spam a bunch of unrelevant tickets on my repos.

@miguelsmuller
Copy link

ok dude. sorry.

only I commented because it is the same with me. even though the updated packages.
from my point of view the topic still on the same subject.

but thank you anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants