-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tjh/add notebooks #37
base: v2
Are you sure you want to change the base?
Conversation
…o tjh/add_notebooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some comments regarding paths .... is this ready for merge or simply a pending pr??
@@ -217,7 +198,7 @@ | |||
"metadata": {}, | |||
"outputs": [], | |||
"source": [ | |||
"cshoreio = wrr.cshoreio(pathPrefix='/Users/rdchlth9/Codes/cmtb_refactor/notetbooks/cshore/data', fNameBase=fname+'_cmtb', versionPrefix='base',\n", | |||
"cshoreio = wrr.cshoreio(workingDirectory='/Users/rdchlth9/Codes/cmtb_refactor/notetbooks/cshore/data', testName=fname+'_cmtb', versionPrefix='base',\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thesser1 can we make these paths generic (relative or something like [/your/path/here])
@@ -357,7 +338,7 @@ | |||
"metadata": {}, | |||
"outputs": [], | |||
"source": [ | |||
"cshoreiofull = wrr.cshoreio(pathPrefix='/Users/rdchlth9/Codes/cmtb_refactor/notetbooks/cshore/data', fNameBase=fname+'_cmtb_full', versionPrefix='base',\n", | |||
"cshoreiofull = wrr.cshoreio(workingDirectory='/Users/rdchlth9/Codes/cmtb_refactor/notetbooks/cshore/data', testName=fname+'_cmtb_full', versionPrefix='base',\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -450,8 +424,8 @@ | |||
"yy['simulationDuration'] = simduration\n", | |||
"yy['modelExecutable'] = '/Users/rdchlth9/Public/cshore/src-repo/cshore.exe'\n", | |||
"yy['workingDirectory'] = '/data'\n", | |||
"yy['netCDFdir'] = '/thredds_data'\n", | |||
"yy['logfileLoc'] = '/cmtb_refactor/data'\n", | |||
"yy['netCDFdir'] = '/Users/rdchlth9/Codes/cmtb_refactor/thredds_data'\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
"yy['netCDFdir'] = '/thredds_data'\n", | ||
"yy['logfileLoc'] = '/cmtb_refactor/data'\n", | ||
"yy['netCDFdir'] = '/Users/rdchlth9/Codes/cmtb_refactor/thredds_data'\n", | ||
"yy['logfileLoc'] = '/Users/rdchlth9/Codes/cmtb_refactor/data'\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
endTime: '2018-03-06T00:00:00Z' | ||
generateFlag: true | ||
logfileLoc: ./cmtb_refactor/data | ||
modelExecutable: /Users/rdchlth9/Public/cshore/src-repo/cshore.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
endTime: '2018-03-06T00:00:00Z' | ||
generateFlag: true | ||
logfileLoc: ./cmtb_refactor/data | ||
modelExecutable: /Users/rdchlth9/Public/cshore/src-repo/cshore.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
…o tjh/add_notebooks
run codes for ww3 and cshore with jupyter notebooks with run examples.