chore(framework): remove component features #10624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested review from
nnaydenow,
MapTo0,
pskelin,
tsanislavgatev and
ilhan007
pskelin
reviewed
Jan 22, 2025
packages/main/README.md
Outdated
| ```js | ||
| // @deprecated this import is no longer needed as of 2.7.0 |
There was a problem hiding this comment.
instead of deprecating this, we can document that it can be preloaded by static import so that a dynamic import can be skipped if the app decides this is better for user experience
pskelin
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both components with features (
Input.tsandColorPalette.ts) have already been reworked. This change is a follow-up cleanup.Changes:
ComponentFeatureclass is no longer needed and can be safely removed (the base features registry still remains for framework features such asOpenUI5Support.ts).InputSuggestions.jsandColorPickerMoreColors.jsremoved from JSDocREADME.mdupdated