fix(ui5-toolbar): correct event handlers attachment #10546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgogov
approved these changes
Jan 17, 2025
nnaydenow
reviewed
Jan 17, 2025
| button.get(0).addEventListener("click", cy.stub().as("clicked")); | ||
| }); | ||
|
|
||
| cy.get("ui5-button", { includeShadowDom: true }).contains("Button 1") |
There was a problem hiding this comment.
can we add test for select as well
vladitasev
approved these changes
Jan 20, 2025
|
🎉 This PR is included in version v2.7.0-rc.1 🎉 The release is available on v2.7.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10415
The Toolbar component now attaches event listeners directly in the template, replacing the previous onEnterDOM approach. This ensures handlers are available immediately after rendering, resolving race conditions and improving test reliability.
Event handling is now managed by the abstract items themselves, rather than the toolbar mediating events. Items fire a new internal "close-overflow" event to notify the toolbar when the overflow menu should close.