feat(ui5-timeline): introduce "growing" property #10470
Conversation
packages/fiori/src/Timeline.ts
Outdated
| } | ||
|
|
||
| get timelineEndDOM() { | ||
| return this.shadowRoot!.querySelector(".ui5-timeline-end-marker"); |
There was a problem hiding this comment.
the best practice is to use @query for this, but it's ok to leave it, just FYI
There was a problem hiding this comment.
A tentative suggestion to align the commit message text with the changes we discussed (for example: use "end" instead of "bottom" when referring to the Timeline's items' list visual end):
Similar to 'ui5-table' , we introduce a new property 'growing' to 'ui-timeline'. It provides growing property, with 3 available options:
'Button': Displays a "More" button at the end of the list, which when pressed triggers the 'load-more' event.
'Scroll': The 'load-more' event is triggered when the user scrolls to the bottom of the list.
'None': The growing functionality is off.
hinzzx
dismissed
their stale review
stale, still we gotta discuss the item navigation behaviour.
There was a problem hiding this comment.
The item navigation behaviour would be handled in separate change, as it was discussed with @vladitasev and @DMihaylova, hence I am removing my change request.
Similar to
ui5-table, we introduce a new propertygrowingtoui5-timeline. It provides growing property, with 3 available options:Button: Displays a "More" button at the end of the list, which when pressed triggers the 'load-more' event.Scroll: The 'load-more' event is triggered when the user scrolls to the bottom of the list.None: The growing functionality is off.fixes: #10154