-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VariantManagament: Missing button to save changes to already saved view #6617
Comments
Hi @superdyzio I wasn't able to reproduce this issue, the save button is displayed for me if the |
hi @Lukas742, thanks for the effort! however, I'd still suggest aligning this logic to be more consistent, because right now I can have
btw what's the reasoning behind current |
@superdyzio you're right, I also noticed that when looking into the behavior of the other issue you raised. The PR you've opened will fix this as well. Thanks again :) |
🎉 This issue has been resolved in version v2.5.0 🎉 The release is available on v2.5.0 Your semantic-release bot 📦🚀 |
Describe the bug
It looks like in the variant manager, we don’t have the option to save changes to the already saved view. At the moment, after introducing changes, we can only save it as a new view.
It works correctly from time to time, but there is no clear rule.
The
data-readonly
attribute was not present on the item and still there was noSave
button. We also tried completely removingreadOnly
property from the variant object passed to the component and still noSave
button.Isolated Example
No response
Reproduction steps
Save
button)Expected Behaviour
Save
button is visible when a variant that is not readonly was modified.Screenshots or Videos
UI5 Web Components for React Version
2.1.1
UI5 Web Components Version
2.2.0
Browser
Chrome
Operating System
MacOS Sequoia 15.1
Additional Context
Analytical tables used with the VariantManagament are very big, up to almost 300 columns and god-knows-how-many rows.
We keep our variants in the local storage, including
readOnly
field and we confirmed that it is not getting any default value when retrieved.Relevant log output
No response
Organization
SAP Fioneer
Declaration
The text was updated successfully, but these errors were encountered: