Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: different label arrangement depending on the selected theme #6340

Closed
1 task done
saynesy opened this issue Sep 11, 2024 · 2 comments · Fixed by #6440
Closed
1 task done

Form: different label arrangement depending on the selected theme #6340

saynesy opened this issue Sep 11, 2024 · 2 comments · Fixed by #6440

Comments

@saynesy
Copy link

saynesy commented Sep 11, 2024

Describe the bug

Depending on the selected theme, the position of the label changes, which makes the labelSpan property in Form non-functional.

I've noticed that for some themes, the --ui5-v2-1-2-form-item-layout CSS variable is not defined which may lead to such a problem.

Isolated Example

https://stackblitz.com/edit/github-jewrmx?file=src%2FApp.tsx

Reproduction steps

No response

Expected Behaviour

Have the same layout of items inside the form according to the given layout and labelSpan props in all themes.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.0.2

UI5 Web Components Version

2.1.2

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@MarcusNotheis
Copy link
Contributor

Hi @saynesy,
thanks for reporting! I think this issue has already been fixed by the UI5 Web Components Team in SAP/ui5-webcomponents#9800, but as far as I know this fix has not been released yet.
I'll keep the issue open until the UI5 Web Components will ship their next release.

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.2.0 🎉

The release is available on v2.2.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants