Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF_ACC][MessageBox][AXE]: MessageBox should not have "more than one contentinfo landmark" error when opened #5644

Closed
1 task done
ksblklu opened this issue Mar 27, 2024 · 1 comment · Fixed by #5645
Closed
1 task done

[SF_ACC][MessageBox][AXE]: MessageBox should not have "more than one contentinfo landmark" error when opened #5644

ksblklu opened this issue Mar 27, 2024 · 1 comment · Fixed by #5645
Labels
released

Comments

@ksblklu
Copy link

ksblklu commented Mar 27, 2024

Describe the bug

Axe error detected MessageBox footer have accessibility issue "Document should not have more than one contentinfo landmark" when opened.

Isolated Example

https://ui5-wstackblitz.com/edit/github-ftnb38?file=src%2FApp.tsx

Reproduction steps

  1. Go to StackBlitz example
  2. Open MessageBox, and run Axe dev tools with "Best Practice" enabled(In axe dev tools - settings)
  3. See the error was reported

Expected Behaviour

MessageBox should not have more than one contentinfo landmark error when opened.
image

Screenshots or Videos

No response

UI5 Web Components for React Version

1.26.0

UI5 Web Components Version

1.23.0

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ksblklu ksblklu added the bug label Mar 27, 2024
@ksblklu ksblklu changed the title [SF_ACC][MessageBox]: MessageBox should not have more than one contentinfo landmark [SF_ACC][MessageBox][AXE]: MessageBox should not have more than one contentinfo landmark Mar 27, 2024
@ksblklu ksblklu changed the title [SF_ACC][MessageBox][AXE]: MessageBox should not have more than one contentinfo landmark [SF_ACC][MessageBox][AXE]: MessageBox should not have "more than one contentinfo landmark" error when opened Mar 27, 2024
@Lukas742 Lukas742 mentioned this issue Mar 27, 2024
Merged
MarcusNotheis pushed a commit that referenced this issue Mar 28, 2024
@Lukas742
fix(MessageBox): replace duplicate footer and header tag (#5645)
3a1bc7b 
Fixes #5644
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.27.0 🎉

The release is available on v1.27.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
ui5-webcomponents-react Roadmap
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(MessageBox): replace duplicate footer and header tag SAP/ui5-webcomponents-react
2 participants
@ksblklu @ui5-webcomponents-react-bot