Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form]: padding-block-end on label makes it hard to see label and value as a unit #5603

Closed
1 task done
rchrdchn opened this issue Mar 13, 2024 · 2 comments · Fixed by #5653
Closed
1 task done

[Form]: padding-block-end on label makes it hard to see label and value as a unit #5603

rchrdchn opened this issue Mar 13, 2024 · 2 comments · Fixed by #5653

Comments

@rchrdchn
Copy link
Contributor

rchrdchn commented Mar 13, 2024

Describe the bug

It makes it hard to see label and value as a unit when the form labelSpan(X) is set to 12 (label and value are stacked on top of each other).

With padding-block-end: 0.25rem
SCR-20240313-krdo

Without padding-block-end: 0.25rem
SCR-20240313-krjb

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-form--docs

Reproduction steps

  1. go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-form--docs
  2. change the labelSpan(X) props to 12
  3. label and value stack vertically
  4. visually, there is almost equal amount of padding in the bottom of the label and value that makes hard to see as label and value are a unit

Expected Behaviour

visually, label and value should looks like they are a unit.

SCR-20240313-krjb

Screenshots or Videos

label-value-vertical-spacing

UI5 Web Components for React Version

v1.26.0

UI5 Web Components Version

1.19.1

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@rchrdchn rchrdchn added the bug label Mar 13, 2024
@rchrdchn rchrdchn changed the title [Form]: padding-block-end makes it hard to see label and value as a unit [Form]: padding-block-end on label makes it hard to see label and value as a unit Mar 13, 2024
@rchrdchn
Copy link
Contributor Author

rchrdchn commented Apr 1, 2024

Reference to a new web component: SAP/ui5-webcomponents#8281

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.27.0 🎉

The release is available on v1.27.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants