Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalyticalTable | a11y : For AnalyticalTable Focus is coming for non-interactive Empty Text #5467

Closed
1 task done
yoganjan opened this issue Feb 5, 2024 · 3 comments · Fixed by #5471
Closed
1 task done
Labels

Comments

@yoganjan
Copy link

yoganjan commented Feb 5, 2024

Bug Description

For AnalyticalTable , When we are tabbing using keyboard, we see that focus is coming for non interactive empty box .

image

Affected Component

AnalyticalTable

Expected Behaviour

Focus should not be coming for empty box

Isolated Example

No response

Steps to Reproduce

  1. Login https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-analyticaltable--docs
  2. Using Tab key of the keyboard, try to focus the Header column
  3. Observe that the focus is coming for empty box

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@yoganjan yoganjan added the bug label Feb 5, 2024
@Lukas742
Copy link
Contributor

Lukas742 commented Feb 5, 2024

Thanks for reporting! I'll forward this issue to the UI5 Web Components for React repo as the affected component is developed there.

@Lukas742
Copy link
Contributor

Lukas742 commented Feb 5, 2024

Hi @yoganjan

the linked PR will fix the issue, that when you initially tab into the table, the first cell regardless of the content is selected. After the PR has been merged and released, it is now always the first cell with content, i.e. the "Name" cell in your screenshot, that is focused.

Although, the empty select-all cell will still be focusable. The cell is still inside a table and omitting it would create discrepancies between other SAP/OpenUI5 table, where the behavior is the same. (E.g. see here)
Also, I would find it strange if a cell is skipped, especially when using screen readers.

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.25.0 🎉

The release is available on v1.25.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants