Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalyticalTable: include empty rows in AnalyticalTableVisibleRowCountMode.Auto #5341

Closed
ej612 opened this issue Dec 12, 2023 · 4 comments · Fixed by #5347
Closed

AnalyticalTable: include empty rows in AnalyticalTableVisibleRowCountMode.Auto #5341

ej612 opened this issue Dec 12, 2023 · 4 comments · Fixed by #5347
Labels

Comments

@ej612
Copy link
Contributor

ej612 commented Dec 12, 2023

Describe the bug

Hi there,

We have an AnalyticalTable that we want to grow with its container, i.e. it's supposed to take up all available vertical space by adding blank rows. From the docs, it seems to me that this is what AnalyticalTableVisibleRowCountMode.Auto is supposed to do:

"Auto": The number of visible rows displayed depends on the height of the surrounding container.

However, that doesn't work for me. I have created a sandbox:

Expected behavior

The red container has a fixed height and should be completely covered by the table, i.e. no red should be visible.

Actual behavior

The table adds only exactly 3 blank rows, whether I use Auto or Fixed.

Am I doing it wrong? Thanks a lot in advance.

UI5 Web Components for React Version

1.21.0

UI5 Web Components Version

1.18.0

Browser

Chrome

Operating System

Windows 11

@Lukas742
Copy link
Contributor

Hi @ej612

the table will only fill the content of non empty rows (visible rows). You can control how many empty rows you always want to show by using the minRows prop.

https://codesandbox.io/s/wild-wildflower-s3djyd?file=/src/App.js

@Lukas742 Lukas742 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@Lukas742 Lukas742 added consulting and removed bug labels Dec 12, 2023
@ej612
Copy link
Contributor Author

ej612 commented Dec 12, 2023

Hi @Lukas742

Thanks a lot for your response. I should have given you more context: Our AnalyticalTable is inside a resizable dialog, which means the available vertical space is not known beforehand. I therefore don't think setting minRows does the trick for me. Let me explain:

  • I have a table with 2 data rows.
  • The container is big enough for the table to fit 10 rows, so if I had 15 data rows, the table would show 10, and add a scrollbar for the remaining 5.
  • I don't want to hardcode something like minRows=25, because it makes no sense for a scrollbar to be shown and as the user scrolls down, all there is is empty rows.
  • I would therefore, if I have 2 data rows, and the table has enough space to show 10, like the table to add exactly 8 blank rows.
    Is there a way to do this currently? And if not, could I request a new AnalyticalTableVisibleRowCountMode.Fill to be added that does this?

Thanks a lot!

@Lukas742
Copy link
Contributor

Hi @ej612

this is a valid feature request as this behavior makes sense and is also present in the SAP/OpenUI5 table. I am now reopening this issue and making it a feature request. I hope you don't mind that I have updated the title accordingly.

@Lukas742 Lukas742 reopened this Dec 14, 2023
@Lukas742 Lukas742 changed the title AnalyticalTable: AnalyticalTableVisibleRowCountMode.Auto doesn't make table fill container AnalyticalTable: include empty rows in AnalyticalTableVisibleRowCountMode.Auto Dec 14, 2023
@Lukas742 Lukas742 moved this from 🆕 New to 2023-Q4 in ui5-webcomponents-react Roadmap Dec 14, 2023
Lukas742 added a commit that referenced this issue Jan 9, 2024
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.24.0 🎉

The release is available on v1.24.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 2023-Q4
3 participants