fix(StyleStore): fix stale reference leading to memory leak (#6651)

Fixes #6649
SAP · Nov 22, 2024 · b51cb24 · b51cb24
1 parent b630a80
commit b51cb24
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/base/src/stores/StyleStore.ts b/packages/base/src/stores/StyleStore.ts
@@ -39,9 +39,14 @@ function getSnapshot(): IStyleStore {
 
 function subscribe(listener: () => void) {
   const listeners = getListeners();
-  STORE_LOCATION[getStyleStoreListenersSymbol()] = [...listeners, listener];
+  listeners.push(listener);
+
   return () => {
-    STORE_LOCATION[getStyleStoreListenersSymbol()] = listeners.filter((l) => l !== listener);
+    const updatedListeners = getListeners();
+    const index = updatedListeners.indexOf(listener);
+    if (index !== -1) {
+      updatedListeners.splice(index, 1);
+    }
   };
 }