Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FIX] adapters/Memory: Return cloned resources" #263

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Jul 29, 2020

Reverts #235 as discussed in todays planning.

We don't want to release #235 without #259. However, #259 breaks tests in ui5-builder and might be incompatible in general. Also it's currently not critical for us.

@RandomByte RandomByte requested a review from matz3 July 29, 2020 14:12
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 86.617% when pulling 5137d6d on revert-235-fix-memory-adapter into 08705a2 on master.

@RandomByte
Copy link
Member Author

Changelog is generated as expected with an entry for the [FIX] and the revert

@RandomByte RandomByte merged commit 9d869b6 into master Jul 30, 2020
@RandomByte RandomByte deleted the revert-235-fix-memory-adapter branch July 30, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants