Skip to content

Commit

Permalink
[DEPENDENCY] Pin dir-glob to v2.0.0
Browse files Browse the repository at this point in the history
dir-glob is a transitive dependency of globby ("dir-glob": "^2.0.0").

Some of our tests ("GLOB root directory" and "GLOB (normalized) root
directory (=> fs root)") are failing when using dir-glob v2.2.0.

Therefore pinning it to v2.0.0 for the time being.

This came up in our preflight tests which ignore the package-lock.json:
npm install --no-shrinkwrap --no-package-lock

Note: This is unrelated to #71
Tests were still failing after reverting that change.

Moreover, this is also reproducible on Git tag v0.2.0.
  • Loading branch information
RandomByte committed Jan 10, 2019
1 parent 4077f19 commit b921fbc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 38 deletions.
52 changes: 14 additions & 38 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
"dependencies": {
"@ui5/logger": "^1.0.0",
"clone": "^2.1.0",
"dir-glob": "2.0.0",
"globby": "^7.1.1",
"graceful-fs": "^4.1.15",
"make-dir": "^1.1.0",
Expand Down

0 comments on commit b921fbc

Please sign in to comment.