Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] enable build with CSS variables #722

Closed
wants to merge 7 commits into from
Closed

[FEATURE] enable build with CSS variables #722

wants to merge 7 commits into from

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Mar 24, 2022

No description provided.

@flovogt flovogt requested a review from matz3 March 24, 2022 13:09
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 94.747% when pulling ba54f72 on css-variables-api into 81285b3 on master.

@flovogt flovogt changed the title [FEAT]: enable build with CSS variables [FEAT] enable build with CSS variables Mar 24, 2022
@flovogt flovogt changed the title [FEAT] enable build with CSS variables [FEATURE] enable build with CSS variables Mar 24, 2022
codeworrior
codeworrior reviewed Mar 25, 2022
View reviewed changes
lib/tasks/TaskUtil.js Outdated Show resolved Hide resolved
@matz3
Copy link
Member

matz3 commented Mar 30, 2022

PR should go into the next branch, not master.

@flovogt flovogt changed the base branch from master to next March 30, 2022 13:10
@flovogt flovogt changed the base branch from next to master March 30, 2022 13:11
@flovogt
Copy link
Member Author

flovogt commented Mar 30, 2022 •
edited
Loading

Superseded by #728.

@flovogt flovogt closed this Mar 30, 2022
@flovogt flovogt deleted the css-variables-api branch March 30, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeworrior codeworrior codeworrior left review comments

@matz3 matz3 Awaiting requested review from matz3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovogt @coveralls @matz3 @codeworrior