[FEATURE] Add 'generateThemeDesignerResources' task #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
generateThemeDesignerResources
branch
from
4ce59d7 to
46c9824
Compare
RandomByte
reviewed
Jan 12, 2021
| * @param {object} parameters.options Options | ||
| * @param {string} parameters.options.projectName Project name | ||
| * @param {string} parameters.options.version Project version | ||
| * @param {string} [parameters.options.namespace] Namespace of the library |
There was a problem hiding this comment.
Suggested change
| * @param {string} [parameters.options.namespace] Namespace of the library | |
| * @param {string} [parameters.options.namespace] If the project is a library, provide its namespace. Omit for theme-libraries |
RandomByte
requested changes
Jan 14, 2021
| `Error: ENOENT: no such file or directory, open /resources/sap/ui/core/themes/sap_fiori_3/foo.less` | ||
| }); | ||
|
|
||
| t.is(fs.readFile.callCount, 1, "fs.readFile should not be called"); |
There was a problem hiding this comment.
Suggested change
| t.is(fs.readFile.callCount, 1, "fs.readFile should not be called"); | |
| t.is(fs.readFile.callCount, 1, "fs.readFile should be called once"); |
| if (err.code === "ENOENT") { | ||
| throw new Error( | ||
| `libraryLessGenerator: Unable to resolve import '${originalFilePath}' from '${baseDir}'\n` + | ||
| err |
There was a problem hiding this comment.
Suggested change
| err | |
| err.message |
?
| err | ||
| ); | ||
| } else { | ||
| throw err; |
There was a problem hiding this comment.
Uncovered line (and branch). Should be easy to test, just like the other branch.
| sinon.restore(); | ||
| }); | ||
|
|
||
| test.serial("processor", async (t) => { |
There was a problem hiding this comment.
Why are all the tests serial? I don't see how they could interfere with one another.
There was a problem hiding this comment.
I think I've added it because of the sinon.restore() in the afterEach hook.
But restoring isn't required as no existing functions are spied/stubbed.
| ["/resources/sap/ui/demo/lib/themes/sap_fiori_3/.theming"]); | ||
|
|
||
| t.is(workspace.write.callCount, 7); | ||
| t.is(workspace.write.getCall(0).args.length, 1); |
There was a problem hiding this comment.
I would appreciate some assertion messages here. Especially in those cases where no named variable is used.
RandomByte
requested changes
Jan 14, 2021
| t.is(workspace.write.getCall(1).args[0], libraryLessResource); | ||
| }); | ||
|
|
||
| test.serial("generateThemeDesignerResources: Library sap.ui.documentation", async (t) => { |
There was a problem hiding this comment.
Suggested change
| test.serial("generateThemeDesignerResources: Library sap.ui.documentation", async (t) => { | |
| test.serial("generateThemeDesignerResources: Library sap.ui.documentation is skipped", async (t) => { |
Generates resources required for integration with the SAP Theme Designer. The task is not enabled by default as it is only relevant for the OpenUI5 / SAPUI5 libraries.
matz3
force-pushed
the
generateThemeDesignerResources
branch
from
a22908a to
f765802
Compare
RandomByte
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.