[FIX] JSModuleAnalyzer: Properly handle jQuery.sap.registerPreloadedModules calls #546
+56
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
fix-JSModuleAnalyzer-legacy-apis
branch
from
2d442fe to
19d7e6a
Compare
|
I like this +1 |
codeworrior
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
I'm also fine with the fix, but I have the impression that there's a more fundamental problem behind. In old (pre-evo) sources, jQuery.sap.global should be treated as a raw module and should not be analysed at all (as it is the loader and contains the API implementations).
Anyhow, improving the robustness of the analyser code is in general a good idea..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/SAP/ui5-builder/issues/544