Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Theme Build: Add compress option to minify output #295

Merged
merged 3 commits into from
Aug 1, 2019
Merged

[FEATURE] Theme Build: Add compress option to minify output #295

merged 3 commits into from
Aug 1, 2019

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jul 18, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jul 23, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 86.274% when pulling a00a349 on theme-build-compress-option into df7c789 on master.

@matz3 matz3 requested review from RandomByte, tobiasso85 and Thodd July 23, 2019 14:50
@matz3
Copy link
Member Author

matz3 commented Jul 23, 2019

This now by default activates the compress option when running a build, which is the expected behavior I think.
The server will still serve the "debug" CSS.

@matz3 matz3 added the enhancement New feature or request label Jul 26, 2019
RandomByte
RandomByte reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests for the processors compress option set to false would be good I guess

@matz3
Copy link
Member Author

matz3 commented Aug 1, 2019

Done

@RandomByte RandomByte requested a review from devtomtom August 1, 2019 10:15
@matz3 matz3 merged commit eea10ba into master Aug 1, 2019
@matz3 matz3 deleted the theme-build-compress-option branch August 1, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@tobiasso85 tobiasso85 Awaiting requested review from tobiasso85

@Thodd Thodd Awaiting requested review from Thodd

@devtomtom devtomtom Awaiting requested review from devtomtom

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @coveralls @RandomByte