Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] package.json: Fix JSDoc version to 3.5.5 #247

Merged
merged 1 commit into from
May 8, 2019

Conversation

RandomByte
Copy link
Member

This resolves an error "Cannot read property 'items' of undefined" when
executing the JSDoc build for the sap.ui.core library.

This resolves an error "Cannot read property 'items' of undefined" when
executing the JSDoc build for the sap.ui.core library.
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, an integration test would be fine. But to fix the immediate issue, we should IMO merge this change.

@RandomByte RandomByte merged commit 873469d into master May 8, 2019
@RandomByte RandomByte deleted the fix-jsdoc-version-355 branch May 8, 2019 14:38
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 85.316% when pulling 961fe81 on fix-jsdoc-version-355 into bdac6be on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants