Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] generateFlexChangesBundle: Handle minUI5Version as array (#1009) #1011

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

RandomByte
Copy link
Member

With the upcoming UI5 2.x the manifest may contain a minUI5Version with
multiple entries as described in the AppDescriptor schema (internal PR
499). This change enables the generateFlexChangesBundle to understand
the new syntax

in addition, the tests for the generateFlexChangesBundle were enhanced
to check better their complete functionality - boy scouted!

JIRA: CLOUDIOI-1170
(cherry picked from commit 45c9b7e)

…1009)

With the upcoming UI5 2.x the manifest may contain a minUI5Version with
multiple entries as described in the AppDescriptor schema (internal PR
499). This change enables the generateFlexChangesBundle to understand
the new syntax

in addition, the tests for the generateFlexChangesBundle were enhanced
to check better their complete functionality - boy scouted!

JIRA: CLOUDIOI-1170
(cherry picked from commit 45c9b7e)
@coveralls
Copy link

Coverage Status

coverage: 94.642% (-0.01%) from 94.653%
when pulling 33611df on minUI5VersionArrays-main
into 2e96225 on main.

@RandomByte RandomByte merged commit 1061ed5 into main Apr 24, 2024
17 checks passed
@RandomByte RandomByte deleted the minUI5VersionArrays-main branch April 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants