[FEATURE] Add 'libraryLessGenerator' processor #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
previously requested changes
Dec 15, 2020
RandomByte
reviewed
Dec 15, 2020
| sinon.restore(); | ||
| }); | ||
|
|
||
| test.serial("processor", async (t) => { |
There was a problem hiding this comment.
Is .serial actually necessary?
|
I'm mostly fine with this change. But as discussed, we should rather merge it into a dedicated branch where we can then add the corresponding |
matz3
commented
Dec 16, 2020
|
|
||
| const IMPORT_PATTERN = /@import .*"(.*)";/g; | ||
| const BASE_LESS_PATTERN = /^\/resources\/sap\/ui\/core\/themes\/([^/]+)\/base\.less$/; | ||
| const GLOBAL_LESS_PATTERN = /^\/resources\/sap\/ui\/core\/themes\/([^/]+)\/global\.(less|css)$/; |
There was a problem hiding this comment.
The global.css was only relevant for old themes.
The only reference I could still find is in "sap_platinum" which has been removed with 1.48, so I think it's save to also not handle it in here.
KlattG
previously approved these changes
Dec 17, 2020
RandomByte
approved these changes
Dec 17, 2020
|
Merged into |
matz3
added a commit
that referenced
this pull request
Jan 14, 2021
matz3
added a commit
that referenced
this pull request
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-264