Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cachebuster type timestamp is using local time #410

Closed
lukasriederle opened this issue Jul 25, 2019 · 2 comments
Closed

cachebuster type timestamp is using local time #410

lukasriederle opened this issue Jul 25, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request module/ui5-builder Related to the UI5 Builder module

Comments

@lukasriederle
Copy link

Expected Behavior

timestamp for cachebuster should be generated in a central timezone

Current Behavior

timestamp is written in local timezone and therefore leads to an error:
time stamp 2019-07-25 16:25:14 is 5221.004068479 s in the future when starting soon.

Steps to reproduce the issue

  1. generate app in e.g. German Timezone. then run it imediately on a server with time difference.

Log Output / Stack Trace

[PollStageAppStatusExecution]  8be308c5-b2a9-4a43-ab9d-01f76fd1529e [Tue Jul 29 09:43:32 UTC 49565270] Copying droplet into the container failed: stream-in: nstar: error streaming in: exit status 2. Output: tar: ./app/public/Component-dbg.js: time stamp 2019-07-25 16:25:14 is 5221.004068479 s in the future (STDERR, CELL)#
@RandomByte
Copy link
Member

RandomByte commented Jul 26, 2019

Related: SAP/ui5-builder#294 (comment) actually not related

@matz3 matz3 self-assigned this Jul 26, 2019
@RandomByte RandomByte transferred this issue from SAP/ui5-tooling Oct 10, 2019
@matz3
Copy link
Member

matz3 commented Mar 31, 2020

The task uses getTime() on the modified date of the file, which returns the milliseconds since Jan 1 1970 UTC, so it should not differ depending on the timezone
https://github.com/SAP/ui5-builder/blob/9b5498a254ed7d1b008c640d01981861dc25bbd4/lib/tasks/generateCachebusterInfo.js#L5

Maybe the server-side part is interpreting the UTC time with its local time?
At least I can not see where this could be solved in the builder/task, thus closing this issue.

@matz3 matz3 closed this as completed Mar 31, 2020
@RandomByte RandomByte transferred this issue from SAP/ui5-builder Nov 20, 2020
@RandomByte RandomByte added enhancement New feature or request module/ui5-builder Related to the UI5 Builder module labels Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module/ui5-builder Related to the UI5 Builder module
Projects
None yet
Development

No branches or pull requests

3 participants