Skip to content

Commit

Permalink
Change logging for missing libraryManifest to verbose
Browse files Browse the repository at this point in the history
With regards to backward compatibility the libraryManifest
can be missing.
When --all is omitted the libraryManifest can also be missing.
  • Loading branch information
tobiasso85 committed Jan 26, 2021
1 parent 8eeab50 commit 42ce003
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/processors/versionInfoGenerator.js
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ async function processManifestAndGetArtifactInfo(libraryManifest, name) {
*/
const processLibraryInfo = async (libraryInfo) => {
if (!libraryInfo.libraryManifest) {
log.warn(
log.verbose(
`Cannot add meta information for library '${libraryInfo.name}'. The manifest.json file cannot be found`);
return;
}
Expand Down
4 changes: 2 additions & 2 deletions test/lib/processors/versionInfoGenerator.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ test.serial("versionInfoGenerator simple library infos", async (t) => {
]
};
assertVersionInfoContent(t, oExpected, result);
t.is(t.context.warnLogStub.callCount, 1);
t.is(t.context.warnLogStub.getCall(0).args[0],
t.is(t.context.verboseLogStub.callCount, 1);
t.is(t.context.verboseLogStub.getCall(0).args[0],
"Cannot add meta information for library 'my.lib'. The manifest.json file cannot be found");
});

Expand Down
4 changes: 2 additions & 2 deletions test/lib/tasks/generateVersionInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ test.serial("integration: Library without i18n bundle file", async (t) => {
"version": "1.33.7",
}, oOptions);

t.is(t.context.warnLogStub.callCount, 1);
t.is(t.context.warnLogStub.getCall(0).args[0],
t.is(t.context.verboseLogStub.callCount, 1);
t.is(t.context.verboseLogStub.getCall(0).args[0],
"Cannot add meta information for library 'test.lib3'. The manifest.json file cannot be found");
});

Expand Down

0 comments on commit 42ce003

Please sign in to comment.