Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare group menu for a11y #12348

Merged
merged 84 commits into from
Jun 11, 2021
Merged

Conversation

Larisa-Staroverova
Copy link
Contributor

No description provided.

@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 7, 2021 13:22 Inactive
@cypress
Copy link

cypress bot commented May 7, 2021



Test summary

2 0 0 0Flakiness 0


Run details

Project spartacus
Status Passed
Commit 3d6cdf1 ℹ️
Started Jun 11, 2021 4:53 AM
Ended Jun 11, 2021 4:54 AM
Duration 01:01 💡
OS Linux Ubuntu - 18.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 11, 2021 04:03 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 11, 2021 04:49 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 12, 2021 04:12 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 12, 2021 07:34 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 12, 2021 10:27 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 12, 2021 13:03 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 12, 2021 14:40 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 12, 2021 15:57 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 17, 2021 05:38 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev May 18, 2021 05:23 Inactive
@Larisa-Staroverova Larisa-Staroverova removed the request for review from Platonn May 18, 2021 07:57
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev June 7, 2021 07:25 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev June 7, 2021 09:12 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev June 7, 2021 12:53 Inactive
ChristophHi
ChristophHi previously approved these changes Jun 7, 2021
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev June 9, 2021 10:17 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev June 9, 2021 12:27 Inactive
@Larisa-Staroverova Larisa-Staroverova temporarily deployed to dev June 10, 2021 06:59 Inactive
@ChristophHi ChristophHi temporarily deployed to dev June 11, 2021 04:41 Inactive
@ChristophHi ChristophHi merged commit bab6215 into develop Jun 11, 2021
@ChristophHi ChristophHi deleted the feature/GH-12089_a11y_group_menu branch June 11, 2021 05:16
@ChristophHi ChristophHi temporarily deployed to dev June 11, 2021 05:16 Inactive
@github-actions
Copy link
Contributor

Public API changes

✔️ Nothing changed in analyzed entry points.

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/account/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/profile/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use buttons instead of links in ConfiguratorGroupMenuComponent
4 participants