Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added support for missing 'showClearButton', 'showMessages', and 'liveMode' properties in FilterBar building block generation. #2953

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

815are
Copy link
Contributor

@815are 815are commented Feb 21, 2025

Issue #2952

Added support for missing 'showClearButton', 'showMessages', and 'liveMode' properties in FilterBar building block generation.:
Documentation - https://sapui5.hana.ondemand.com/sdk/#/api/sap.fe.macros.FilterBar%23controlProperties
Generation example:

<mvc:View xmlns:core="sap.ui.core" xmlns:mvc="sap.ui.core.mvc" xmlns="sap.m" xmlns:html="http://www.w3.org/1999/xhtml" controllerName="com.test.myApp.ext.main.Main" xmlns:macros="sap.fe.macros">
    <Page title="Main">
        <content>
            <macros:FilterBar id="testFilterBar" search="onSearch" filterChanged="onFilterChanged" liveMode="true" showClearButton="false" showMessages="true"/>
        </content>
    </Page>
</mvc:View>

add support for missing filterbar building block properties
changelog
@815are 815are requested a review from a team as a code owner February 21, 2025 11:38
Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: 268f5d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@815are 815are added the fe-fpm-writer @sap-ux/fe-fpm-writer label Feb 21, 2025
@815are 815are force-pushed the fix/2952/missingPropertiesForFilterBarBuildingBlock branch from 70a1604 to fa50037 Compare February 21, 2025 11:59
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding additional options seems clear and covered by tests.
changset ✅

Copy link
Contributor

@broksy broksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset corresponds to the changes made.
Approved from my side.

@815are 815are merged commit 0c37c3d into main Feb 21, 2025
16 checks passed
@815are 815are deleted the fix/2952/missingPropertiesForFilterBarBuildingBlock branch February 21, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-fpm-writer @sap-ux/fe-fpm-writer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants