2821/add cap mta prompting #2889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng MTA to CAP project during deployment
🦋 Changeset detectedLatest commit: 77fffb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
longieirl
force-pushed
the
2821/add-cap-mta-prompting
branch
from
5ac258b to
bbf0d8a
Compare
longieirl
force-pushed
the
2821/add-cap-mta-prompting
branch
from
22ae923 to
bcb7c7d
Compare
|
IainSAP
reviewed
Feb 21, 2025
Comment on lines
+188
to
+207
| if (isCAPMissingMTA) { | ||
| DeploymentGenerator.logger?.debug(t('cfGen.debug.capMissingMTA')); | ||
| // If launched as root generator, add a prompt to allow user decide if they want to add an MTA config | ||
| let questions = (await getCFApprouterQuestionsForCap({ | ||
| projectRoot: this.projectRoot ?? process.cwd() | ||
| })) as Question[]; | ||
| questions = withCondition(questions, (answers: Answers) => answers.addCapMtaContinue === true); | ||
| questions.unshift(...getConfirmMtaContinuePrompt()); | ||
| this.appRouterAnswers = (await this.prompt(questions)) as CfAppRouterDeployConfigAnswers; | ||
| if ((this.appRouterAnswers as Answers).addCapMtaContinue !== true) { | ||
| this.abort = true; | ||
| return; | ||
| } | ||
| // Configure defaults | ||
| this.destinationName = DefaultMTADestination; | ||
| this.options.overwrite = true; // Don't prompt the user to overwrite files we've just written! | ||
| this.answers = {}; | ||
| this.answers.destinationName = this.destinationName; | ||
| this.answers.addManagedAppRouter = false; | ||
| } else { |
There was a problem hiding this comment.
Maybe put all the mta related code in this condition into a new function? But its just a suggestion.
IainSAP
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thanks @longieirl
- Code is clear
- Good test coverage added
- Not tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2821
Please note,
Add deploymentoption is not shown to the user on the project attributes page if the mta config is missing, this, this is an as-is flow and is not changing. Launching the deployment generator as a root generator is where this change is only triggered.