Workaround for Node 6.4.0 buffer bug #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 6.4.0 introduced a bug ( nodejs/node#8127 ) that causes a Range Error exceptions when writing a zero-length string to a buffer. The bug was fixed in Node 6.5.0, but the current node-hdb throws Range Error exceptions in Node 6.4.0 when attempting to use streams to read a result set. This change introduces a workaround that checks for zero-length strings, and avoids the write that will fail in Node 6.4.0
alexpenev-s
reviewed
Oct 12, 2016
| @@ -437,7 +437,11 @@ Writer.prototype.writeCharacters = function writeCharacters(value, encoding) { | |||
| var type = encoding === 'ascii' ? TypeCode.STRING : TypeCode.NSTRING; | |||
| var length = Buffer.byteLength(value, encoding); | |||
| var buffer; | |||
| if (length <= 245) { | |||
| if (length === 0 ) { | |||
There was a problem hiding this comment.
We shouldn't make workarounds in the driver in order to support buggy versions of NodeJS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 6.4.0 introduced a bug ( nodejs/node#8127 ) that causes a Range Error exceptions when writing a zero-length string to a buffer. The bug was fixed in Node 6.5.0, but the current node-hdb throws Range Error exceptions in Node 6.4.0 when attempting to use streams to read a result set.
This change introduces a workaround that checks for zero-length strings, and avoids the write that will fail in Node 6.4.0