Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it is possible to have
Task
s which are queued while the database connection is in the process of being disconnected from the database. As the runningTask
is being rejected by theonend
event it will trigger the nextTask
. This task is removed from the queue and send to the connection. Resulting in the connection becoming dormant and the startedTask
hanging. Additionally all queuedTask
s are completely discarded whenonclose
is called. Which makes all the enqueuedTask
s hang.Visual examples
The current behavior:
The behavior of the PR:
Alternative solution would be to call run in the next of the queue with
setImmediate
, but this might come with an performance impact for positive connection scenarios.