Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JWT authentication method #201

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Conversation

cplussharp
Copy link
Contributor

JWT works more or less the same as SAML from a client perspective.

@cla-assistant
Copy link

cla-assistant bot commented Jul 9, 2022

CLA assistant check
All committers have signed the CLA.

@cplussharp
Copy link
Contributor Author

@jeffalbion Can you please review and merge this pull request

@jeffalbion jeffalbion self-requested a review July 27, 2022 16:45
@@ -0,0 +1,40 @@
// Copyright 2022 SAP AG.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be 'SAP SE'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Copy&Paste error. The other files still have SAP AG as they where before the change from AG to SE. I fixed it for this file.

Copy link
Collaborator

@jeffalbion jeffalbion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot for the PR - can you fix the one copyright line and we can submit?

@cplussharp
Copy link
Contributor Author

Hi @jeffalbion

I just saw that JWT was never explained in the SAP HANA SQL Command Network Protocol Reference. Do you know who is responsible for this document?

As LDAP is already explained in the document but yet never implemented in any open source client, would be OK to implement it here?

@jeffalbion jeffalbion merged commit f12206f into SAP:master Aug 4, 2022
@jeffalbion
Copy link
Collaborator

Hi @cplussharp,

The HANA Clients development team at SAP is responsible for the document but it has indeed fallen out of date and was removed in the HANA 2.0 SPS05 help guide. We generally keep internal notes amongst our team now and refer to the source code directly for any questions.

If there is a larger demand for LDAP support for hdb our team can also take a look at enhancing the driver but we haven't heard of any requests to date to my knowledge. LDAP is supported in SAP HANA Cloud now so I agree the support could be useful in some scenarios.

Since this is a community-based driver PR requests are always welcome but please let us know if you're starting work on a major feature like LDAP support so we don't duplicate efforts.

Thanks for your work for the JWT support!

@cplussharp cplussharp deleted the jwt-support branch August 12, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants