Reduce collected variables to only add relevant ones #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When collecting the variables used during compilation there is a high chance for redundancy when multiple compiled files (e.g. library themes) are using the same base files for sharing variables. With this change those variables will be excluded to reduce the size of the variables / inline theming parameters. The full set of variables is available as "allVariables" in the result object.
devtomtom
approved these changes
Feb 8, 2018
matz3
added a commit
that referenced
this pull request
Mar 23, 2018
There has been an issue with the reduced set of variables introduced with #18. In some cases the import paths are absolute which breaks the check with relative file paths within "getVariables". The "mFileMappings" map always contains the correct paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting the variables used during compilation there is a high
chance for redundancy when multiple compiled files (e.g. library themes)
are using the same base files for sharing variables.
With this change those variables will be excluded to reduce the size of
the variables / inline theming parameters.
The full set of variables is available as "allVariables" in the result
object.