Bump eslint from 8.57.0 to 9.8.0 (#359)

* Bump eslint from 8.57.0 to 9.8.0

Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.8.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.57.0...v9.8.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Migrate ESlint to flat config

* Fix ESlint inconsistencies

* Remove ambiguous flattening code

* Remove unused module

* fix: Resolve conflicts

* Resolve conflicts

* Fix tests

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yavor Ivanov <yavor.ivanov@sap.com>

eslint.config.mjs

@@ -0,0 +1,87 @@
+import jsdoc from "eslint-plugin-jsdoc";
+import globals from "globals";
+import js from "@eslint/js";
+import google from "eslint-config-google";
+
+
+export default [
+	js.configs.recommended,
+	google,
+	{
+		ignores: ["lib/thirdparty/"],
+	},
+	{
+		plugins: {
+			jsdoc,
+		},
+
+		languageOptions: {
+			globals: {
+				...globals.node,
+				...globals.mocha,
+			},
+
+			ecmaVersion: 8,
+			sourceType: "commonjs",
+		},
+
+		settings: {
+			jsdoc: {
+				tagNamePreference: {
+					return: "returns",
+				},
+			},
+		},
+
+		rules: {
+			"indent": ["error", "tab"],
+			"linebreak-style": ["error", "unix"],
+
+			"quotes": [
+				"error",
+				"double",
+				{
+					allowTemplateLiterals: true,
+				},
+			],
+
+			"semi": ["error", "always"],
+			"no-negated-condition": "off",
+			"require-jsdoc": "off",
+			"no-mixed-requires": "off",
+
+			"max-len": [
+				"warn", // TODO: set to "error" and fix all findings
+				{
+					code: 120,
+					ignoreUrls: true,
+					ignoreRegExpLiterals: true,
+				},
+			],
+
+			"no-implicit-coercion": [
+				2,
+				{
+					allow: ["!!"],
+				},
+			],
+
+			"comma-dangle": "off",
+			"no-tabs": "off",
+			// This rule must be disabled as of ESLint 9. It's removed and causes issues when present.
+			// https://eslint.org/docs/latest/rules/valid-jsdoc
+			"valid-jsdoc": 0,
+			"jsdoc/require-param-description": 0,
+			"jsdoc/require-returns-description": 0,
+			"jsdoc/require-returns": 0,
+		},
+	},
+	{
+		files: ["**/*.mjs"],
+
+		languageOptions: {
+			ecmaVersion: 2022,
+			sourceType: "module",
+		},
+	},
+];

lib/plugin/variable-collector.js

@@ -39,6 +39,7 @@ VariableCollector.prototype = {
 				filename: node.currentFileInfo.filename,
 				rootFilename: node.currentFileInfo.rootFilename
 			};
+		// eslint-disable-next-line no-unused-vars
 		} catch (err) {
 			// Errors might occur within mixins.
 			// But as we only collect global variables, this doesn't matter...