Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core,platform): multi input and combobox tokenizer behaviour #9571

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Mar 23, 2023

Related Issue(s)

closes #8985

Description

Fixed tokenizer behaviour inside multi-input and multi-combobox components for core and platform implementation;

Screenshots

Before:

Even though we displayed [n] more button, we still didn't hide all tokens, but simply scrolled to the end of them
image

After:

Now tokenizer works according to the guidelines: https://experience.sap.com/fiori-design-web/multiinput/#reviewing-tokens
image

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added enhancement New feature or request platform platform core Core library specific issues labels Mar 23, 2023
@N1XUS N1XUS added this to the Sprint 109 milestone Mar 23, 2023
@N1XUS N1XUS requested a review from a team March 23, 2023 09:39
@N1XUS N1XUS self-assigned this Mar 23, 2023
@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 8def190
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/641d5f2f6e95a700085d3e79
😎 Deploy Preview https://deploy-preview-9571--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@N1XUS N1XUS force-pushed the fix/8985-tokenizer-behaviour branch from 7e114cd to 133fccc Compare March 23, 2023 10:05
@github-actions
Copy link

github-actions bot commented Mar 23, 2023

Visit the preview URL for this PR (updated for commit 8def190):

https://fundamental-ngx-gh--pr9571-fix-8985-tokenizer-b-u4tog48p.web.app

(expires Mon, 27 Mar 2023 08:41:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@N1XUS N1XUS force-pushed the fix/8985-tokenizer-behaviour branch from 1055a0e to 8def190 Compare March 24, 2023 08:28
@N1XUS N1XUS merged commit 7430869 into main Mar 24, 2023
@N1XUS N1XUS deleted the fix/8985-tokenizer-behaviour branch March 24, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues enhancement New feature or request platform platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi input vs. multi combo
2 participants