fix: (Core) Update form message to match Fundamental Styles #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salarenko
added
bug
1 task
|
Deploy preview for fundamental-ngx ready! Built with commit 4de2eea |
| @@ -0,0 +1,26 @@ | |||
| import { MessageStates } from '@fundamental-ngx/core'; | |||
There was a problem hiding this comment.
not a big deal, but this file should be named constants.ts for consistency with the other components.
InnaAtanasova
approved these changes
Dec 3, 2020
|
Please fix Travis and the name of the file. |
Betrozov
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Part of: #3922
Please provide a brief summary of this pull request.
Previous implementation of the Form Message has diverged from Fundamental Styles.
This PR:
fd-form-messageclasses to the host elementcompactinputdisplayproperty toblock(as shown in Fundamental Styles)Breaking change
[compact]input has been removedThe issue found during the deffect hunting was caused by
display: inline.Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md