Timeout #136
Merged
Timeout #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a processing timeout to the component operator framework.
So far, if not all dependent objects of a component were in a
Readystate, the component stayed in aProcessing state, potentially forever. This is now changed. By default, there is a timeout assumed equal to the effective retry interval. If dependents do not get ready within that period, the component state will flip toError(but the reconciler will still continue to reconcile the dependent objects). The timeout restarts counting whenever the component itself changes, or if the generated manifests of the dependent objects change.Components (or their spec) can implement the new interface
TimeoutConfiguration(or embed the convenience typeTimeoutSpec) in order to make the timeout configurable.