Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Enable destination cache by default #5440

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

feat!: Enable destination cache by default #5440

wants to merge 38 commits into from

Conversation

KavithaSiva
Copy link
Collaborator

@KavithaSiva KavithaSiva commented Feb 4, 2025 •
edited by deekshas8
Loading

Closes SAP/cloud-sdk-backlog#ISSUENUMBER.

  • I know which base branch I chose for this PR, as the default branch is v3-main now, which is not for v4 development.
  • If my change will be merged into the main branch (for v4), I've updated (V4-Upgrade-Guide.md)[./V4-Upgrade-Guide.md] in case my change has any implications for users updating to SDK v4

@KavithaSiva KavithaSiva changed the title feat(v4)!: Enable destination cache by deafult feat(v4)!: Enable destination cache by default Feb 4, 2025
@KavithaSiva KavithaSiva marked this pull request as ready for review February 6, 2025 09:10
@deekshas8 deekshas8 changed the title feat(v4)!: Enable destination cache by default feat!: Enable destination cache by default Feb 12, 2025
@deekshas8
Copy link
Contributor

deekshas8 commented Feb 12, 2025 •
edited
Loading

I believe we should also consider getAllDestinationsFromDestinationService

deekshas8
deekshas8 reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

packages/connectivity/src/scp-cf/destination/destination-cache.spec.ts Outdated Show resolved Hide resolved
.../connectivity/src/scp-cf/destination/destination-accessor-provider-subscriber-lookup.spec.ts Outdated
@@ -37,6 +38,8 @@ import {
alwaysSubscriber,
subscriberFirst
} from './destination-selection-strategies';
import { destinationServiceCache } from './destination-service-cache';
import { destinationCache } from './destination-cache';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[req] Instead of importing this, you can change the fetchDestination function and set usecache false there. I believe in the original tests, that was the case we were testing under anyway.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this test contains tests that test both getAllDestinationsFromDestinationService() and getDestinationFromDestinationService(), this I would prefer to import them and clear them instead before tests for a clean state.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was to not change the original premise of the test, which was no caching. We're not testing for caching here (atleast for getDestination) so why bother with having a cache and then clearing it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have disabled caching for the first set of tests, still need it though for tests that cover fetching all destinations.

.../connectivity/src/scp-cf/destination/destination-accessor-provider-subscriber-lookup.spec.ts Outdated Show resolved Hide resolved
deekshas8
deekshas8 reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for one more round. After this we're ready to merge

@KavithaSiva
Copy link
Collaborator Author

Sorry for one more round. After this we're ready to merge

No issues.

deekshas8
deekshas8 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deekshas8 deekshas8 deekshas8 approved these changes

@tomfrenken tomfrenken Awaiting requested review from tomfrenken

@shibeshduw shibeshduw Awaiting requested review from shibeshduw

@ZhongpinWang ZhongpinWang Awaiting requested review from ZhongpinWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KavithaSiva @deekshas8