Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve manifest information #93

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Improve manifest information #93

merged 5 commits into from
Jan 17, 2025

Conversation

margopolo
Copy link
Contributor

Fix terminology, update information on relation between manifest version and OpenUI5 version.

@margopolo margopolo requested a review from silkearians December 5, 2024 10:51
@margopolo margopolo requested review from Thodd and H4ze and removed request for silkearians December 13, 2024 16:25
steps/10/README.md Outdated Show resolved Hide resolved
@margopolo margopolo requested a review from KlattG January 7, 2025 23:01
steps/01/README.md Outdated Show resolved Hide resolved
steps/01/README.md Outdated Show resolved Hide resolved
steps/01/README.md Outdated Show resolved Hide resolved
steps/10/README.md Outdated Show resolved Hide resolved
steps/10/README.md Outdated Show resolved Hide resolved
steps/10/README.md Outdated Show resolved Hide resolved
steps/10/README.md Outdated Show resolved Hide resolved
steps/10/README.md Outdated Show resolved Hide resolved
petermuessig
petermuessig previously approved these changes Jan 13, 2025
Copy link
Contributor

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments

steps/01/README.md Outdated Show resolved Hide resolved
steps/01/README.md Outdated Show resolved Hide resolved
steps/01/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

> 📝 **Note:** <br>
> The manifest version should not necessarily align directly with the OpenUI5 version being used. Instead, choose the descriptor version that matches the requirements or supports the features you intend to use in your application.

To find the appropriate `_version` for each OpenUI5 release, refer to [Descriptor for Applications, Components, and Libraries \(manifest.json\)](https://sdk.openui5.org/topic/be0cf40f61184b358b5faedaec98b2da.html) or the [mapping.json](https://github.com/SAP/ui5-manifest/blob/main/mapping.json) file of the [ui5-manifest](https://github.com/SAP/ui5-manifest/) project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the topic in the documentation will be also adopted in the future to manifest, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked and this is currently the title of the chapter.
@KlattG let us know in case this is changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The topic has recently been renamed to "Manifest (Descriptor for Applications, Components, and Libraries)".
I hope that's fine with you.

@margopolo margopolo merged commit 22d6b89 into main Jan 17, 2025
3 checks passed
@margopolo margopolo deleted the update/manifest_version branch January 17, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants