Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Import of UIComponent for Routing #56

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Adds Import of UIComponent for Routing #56

merged 1 commit into from
Oct 2, 2024

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Oct 2, 2024

Follow-Up of #55

@flovogt flovogt requested a review from KlattG October 2, 2024 06:59
@flovogt flovogt requested a review from akudev October 2, 2024 07:46
@flovogt
Copy link
Member Author

flovogt commented Oct 2, 2024

@petermuessig @akudev should we adjust the JS walkthrough the same way? In JS using the this.getOwnerComponent() has the benefit to not import the sap/ui/core/UIComponent at all.

@akudev
Copy link
Contributor

akudev commented Oct 2, 2024

In JS this is less important, I think. If we are using this.getOwnerComponent() with less imports there, that's fine.

KlattG
KlattG approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovogt flovogt merged commit ba6dfaa into main Oct 2, 2024
3 checks passed
@flovogt flovogt deleted the router-update branch October 2, 2024 13:10
@petermuessig
Copy link
Contributor

Hmmm, isn't Andreas commenting in the other direction? Using this.getOwnerComponent() instead of the import? Both is OK for me - finally it must be consistent - but I'm questioning the merge of the change with the comment above...

@akudev
Copy link
Contributor

akudev commented Oct 2, 2024

@petermuessig that was regarding the JavaScript version. In TypeScript the variant without typecast (= this change) is definitely better.

@margopolo margopolo mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akudev akudev akudev approved these changes

@KlattG KlattG KlattG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovogt @akudev @petermuessig @KlattG