Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use native UrlSearchParams instead of deprecated UriParameters #14

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Jun 12, 2024

Aligns TS tutorial with already updated JS tutorial.

Fixes SAP-docs/sapui5#132.

@flovogt flovogt requested a review from petermuessig June 12, 2024 12:55
Copy link
Contributor

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hungarian notation in TypeScript please!

@flovogt flovogt force-pushed the mockserver-cleanup branch from e2f236f to 02c4cc0 Compare June 12, 2024 13:01
@flovogt
Copy link
Member Author

flovogt commented Jun 12, 2024

No hungarian notation in TypeScript please!

done

@flovogt flovogt requested a review from petermuessig June 12, 2024 13:01
Copy link
Contributor

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! 🥳

@flovogt flovogt merged commit 05fd388 into main Jun 12, 2024
2 checks passed
@flovogt flovogt deleted the mockserver-cleanup branch June 12, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UriParameters is deprecated
3 participants