Skip to content

Commit

Permalink
docs: remove animationMode and improve README wording
Browse files Browse the repository at this point in the history
`animationMode: minimal` is not required and not
setting it simplifies the config.
  • Loading branch information
matz3 committed Nov 7, 2024
1 parent 9ef4b34 commit 9a1c51c
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 17 deletions.
11 changes: 6 additions & 5 deletions steps/27/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,10 @@ We also need a generic test page to run our tests. This is necessary as the name

### webapp/test/testsuite.qunit.ts \(New\)

The `testsuite.qunit.ts` file contains the configuration of our test suite.
It serves as the entry point for all tests within our project.
The `testsuite.qunit.ts` file contains the configuration of our test suite such as using QUnit version 2 and the `sap_horizon` theme.
It serves as the entry point for all tests within our project such as the previously created `unit/unitTests` (The `.qunit.ts` extension is omitted and will be added automatically during runtime).

The previously created `Test.qunit.html` file is referenced as the test `page` which is used to run the individual tests.

For more information, read [Test Starter - Concept and Basic Setup](https://sdk.openui5.org/#/topic/22f50c0f0b104bf3ba84620880793d3f).

Expand All @@ -134,8 +136,7 @@ export default {
version: 2
},
ui5: {
theme: "sap_horizon",
animationMode: "minimal"
theme: "sap_horizon"
},
loader: {
paths: {
Expand All @@ -156,7 +157,7 @@ export default {
### webapp/test/testsuite.qunit.html \(New\)

We also create a corresponding `testsuite.qunit.html` in the same folder.
This is the page we will open in the browser to run our tests.
This is the page we will open in the browser to see a list of all our tests and run them by clicking on the test name.
It registers a resource root mapping for the test resources of our project and references the `testsuite.qunit` module we created in the previous step.

```html
Expand Down
3 changes: 1 addition & 2 deletions steps/27/webapp/test/testsuite.cdn.qunit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export default {
version: 2
},
ui5: {
theme: "sap_horizon",
animationMode: "minimal"
theme: "sap_horizon"
},
loader: {
paths: {
Expand Down
3 changes: 1 addition & 2 deletions steps/27/webapp/test/testsuite.qunit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export default {
version: 2
},
ui5: {
theme: "sap_horizon",
animationMode: "minimal"
theme: "sap_horizon"
},
loader: {
paths: {
Expand Down
3 changes: 1 addition & 2 deletions steps/28/webapp/test/testsuite.cdn.qunit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export default {
version: 2
},
ui5: {
theme: "sap_horizon",
animationMode: "minimal"
theme: "sap_horizon"
},
loader: {
paths: {
Expand Down
3 changes: 1 addition & 2 deletions steps/28/webapp/test/testsuite.qunit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export default {
version: 2
},
ui5: {
theme: "sap_horizon",
animationMode: "minimal"
theme: "sap_horizon"
},
loader: {
paths: {
Expand Down
3 changes: 1 addition & 2 deletions steps/29/webapp/test/testsuite.cdn.qunit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export default {
version: 2
},
ui5: {
theme: "sap_horizon",
animationMode: "minimal"
theme: "sap_horizon"
},
loader: {
paths: {
Expand Down
3 changes: 1 addition & 2 deletions steps/29/webapp/test/testsuite.qunit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export default {
version: 2
},
ui5: {
theme: "sap_horizon",
animationMode: "minimal"
theme: "sap_horizon"
},
loader: {
paths: {
Expand Down

0 comments on commit 9a1c51c

Please sign in to comment.