Skip to content

Commit

Permalink
Use typecasts with as to avoid parser issues in tsx (#13)
Browse files Browse the repository at this point in the history
  • Loading branch information
petermuessig authored Jun 3, 2024
1 parent bc61d3d commit 4547de9
Show file tree
Hide file tree
Showing 184 changed files with 3,177 additions and 2,998 deletions.
4,577 changes: 2,378 additions & 2,199 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"author": "SAP SE",
"private": true,
"devDependencies": {
"archiver": "^6.0.1",
"archiver": "^7.0.1",
"fast-glob": "^3.3.2",
"gh-pages": "^6.1.0"
"gh-pages": "^6.1.1"
},
"workspaces": [
"steps/*"
Expand Down
2 changes: 1 addition & 1 deletion steps/01/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
"start": "ui5 serve -o index.html"
},
"devDependencies": {
"@ui5/cli": "^3.7.1"
"@ui5/cli": "^3.10.3"
}
}
10 changes: 5 additions & 5 deletions steps/02/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
"start": "ui5 serve -o index.html"
},
"devDependencies": {
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/02/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.ui.core
- name: themelib_sap_horizon
Expand Down
10 changes: 5 additions & 5 deletions steps/03/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/03/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
10 changes: 5 additions & 5 deletions steps/04/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/04/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
10 changes: 5 additions & 5 deletions steps/05/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/05/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
10 changes: 5 additions & 5 deletions steps/06/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/06/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
10 changes: 5 additions & 5 deletions steps/07/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/07/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
6 changes: 3 additions & 3 deletions steps/08/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ export default class AppController extends Controller {

onShowHello(): void {
// read msg from i18n model
const recipient = (<JSONModel>this.getView()?.getModel())?.getProperty("/recipient/name");
const resourceBundle = <ResourceBundle>(<ResourceModel>this.getView()?.getModel("i18n"))?.getResourceBundle();
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
const msg = resourceBundle.getText("helloMsg", [recipient]) || "no text defined";
// show message
MessageToast.show(msg);
Expand Down Expand Up @@ -158,4 +158,4 @@ A resource bundle is a flat structure, therefore the preceding slash \(/\) can b

[API Reference: `sap/base/strings/formatMessage`](https://sdk.openui5.org/#/api/module:sap/base/strings/formatMessage)

[Binding Path](https://sdk.openui5.org/topic/2888af49635949eca14fa326d04833b9 "Binding paths address the different properties and lists in a model and define how a node in the hierarchical data tree can be found.")
[Binding Path](https://sdk.openui5.org/topic/2888af49635949eca14fa326d04833b9 "Binding paths address the different properties and lists in a model and define how a node in the hierarchical data tree can be found.")
10 changes: 5 additions & 5 deletions steps/08/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/08/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
4 changes: 2 additions & 2 deletions steps/08/webapp/controller/App.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ export default class AppController extends Controller {

onShowHello(): void {
// read msg from i18n model
const recipient = (<JSONModel>this.getView()?.getModel())?.getProperty("/recipient/name");
const resourceBundle = <ResourceBundle>(<ResourceModel>this.getView()?.getModel("i18n"))?.getResourceBundle();
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
const msg = resourceBundle.getText("helloMsg", [recipient]) || "no text defined";
// show message
MessageToast.show(msg);
Expand Down
6 changes: 3 additions & 3 deletions steps/09/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ import ResourceBundle from "sap/base/i18n/ResourceBundle";
export default class AppController extends Controller {
onShowHello(): void {
// read msg from i18n model
const recipient = (<JSONModel> this.getView()?.getModel())?.getProperty("/recipient/name");
const resourceBundle = <ResourceBundle> (<ResourceModel> this.getView()?.getModel("i18n"))?.getResourceBundle();
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
const msg = resourceBundle.getText("helloMsg", [recipient]) || "no text defined";
// show message
MessageToast.show(msg);
Expand Down Expand Up @@ -172,4 +172,4 @@ new ComponentContainer({

[Advanced Concepts for OpenUI5 Components](https://sdk.openui5.org/topic/ecbc417ff264498b96bc364c53280242.html "Advanced concepts for components include routing and navigation and component data as well as the event bus.")

[API Reference: `sap.ui.core.ComponentContainer`](https://sdk.openui5.org/api/sap.ui.core.ComponentContainer)
[API Reference: `sap.ui.core.ComponentContainer`](https://sdk.openui5.org/api/sap.ui.core.ComponentContainer)
10 changes: 5 additions & 5 deletions steps/09/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/09/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
6 changes: 3 additions & 3 deletions steps/09/webapp/controller/App.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import ResourceBundle from "sap/base/i18n/ResourceBundle";
export default class AppController extends Controller {
onShowHello() : void {
// read msg from i18n model
// functions with generic return values require casting
const resourceBundle = <ResourceBundle> (<ResourceModel> this.getView()?.getModel("i18n"))?.getResourceBundle();
const recipient = (<JSONModel> this.getView()?.getModel())?.getProperty("/recipient/name");
// functions with generic return values require casting
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
const msg = resourceBundle.getText("helloMsg", [recipient]) || "no text defined";
// show message
MessageToast.show(msg);
Expand Down
10 changes: 5 additions & 5 deletions steps/10/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/10/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
4 changes: 2 additions & 2 deletions steps/10/webapp/controller/App.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import ResourceBundle from "sap/base/i18n/ResourceBundle";
export default class AppController extends Controller {
onShowHello() : void {
// read msg from i18n model
const recipient = (<JSONModel> this.getView()?.getModel())?.getProperty("/recipient/name");
const resourceBundle = <ResourceBundle> (<ResourceModel> this.getView()?.getModel("i18n"))?.getResourceBundle();
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
const msg = resourceBundle.getText("helloMsg", [recipient]) || "no text defined";
// show message
MessageToast.show(msg);
Expand Down
10 changes: 5 additions & 5 deletions steps/11/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/11/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
4 changes: 2 additions & 2 deletions steps/11/webapp/controller/App.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import ResourceBundle from "sap/base/i18n/ResourceBundle";
export default class AppController extends Controller {
onShowHello() : void {
// read msg from i18n model
const recipient = (<JSONModel> this.getView()?.getModel())?.getProperty("/recipient/name");
const resourceBundle = <ResourceBundle> (<ResourceModel> this.getView()?.getModel("i18n"))?.getResourceBundle();
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
const msg = resourceBundle.getText("helloMsg", [recipient]) || "no text defined";
// show message
MessageToast.show(msg);
Expand Down
10 changes: 5 additions & 5 deletions steps/12/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@ui5/cli": "^3.7.1",
"typescript": "^5.2.2",
"ui5-middleware-livereload": "^3.0.2",
"ui5-middleware-serveframework": "^3.0.0",
"ui5-tooling-transpile": "^3.2.7"
"@ui5/cli": "^3.10.3",
"typescript": "^5.4.5",
"ui5-middleware-livereload": "^3.0.3",
"ui5-middleware-serveframework": "^3.1.1",
"ui5-tooling-transpile": "^3.4.1"
}
}
2 changes: 1 addition & 1 deletion steps/12/ui5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
type: application
framework:
name: OpenUI5
version: "1.120.1"
version: "1.120.15"
libraries:
- name: sap.m
- name: sap.ui.core
Expand Down
4 changes: 2 additions & 2 deletions steps/12/webapp/controller/App.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import ResourceBundle from "sap/base/i18n/ResourceBundle";
export default class AppController extends Controller {
onShowHello() : void {
// read msg from i18n model
const recipient = (<JSONModel> this.getView()?.getModel())?.getProperty("/recipient/name");
const resourceBundle = <ResourceBundle> (<ResourceModel> this.getView()?.getModel("i18n"))?.getResourceBundle();
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
const msg = resourceBundle.getText("helloMsg", [recipient]) || "no text defined";
// show message
MessageToast.show(msg);
Expand Down
Loading

0 comments on commit 4547de9

Please sign in to comment.