This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Sustain service broker #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrmiskiewicz
requested review from
adamwalach,
jasiu001,
ksputo,
mszostok,
PK85 and
polskikiel
as code owners
piotrmiskiewicz
force-pushed
the
sustain-service-broker
branch
from
128bf89 to
a817ac7
Compare
|
/retest |
jasiu001
reviewed
Jan 3, 2020
| @@ -73,6 +75,13 @@ func TestReconcileClusterAddonsConfiguration_AddAddonsProcess(t *testing.T) { | |||
|
|
|||
| } | |||
|
|
|||
| // newEmptyInstanceChecker returns instanceChecker which behaves like there is no any service instances in the cluster. | |||
| func newEmptyInstanceChecker(t *testing.T) instanceChecker { | |||
jasiu001
reviewed
Jan 3, 2020
| } | ||
|
|
||
| // AnyServiceInstanceExistsForClusterServiceBroker checks whether there is at least one service instance created with helm broker cluster service class. | ||
| func (f *Facade) AnyServiceInstanceExistsForClusterServiceBroker(namespace string) (bool, error) { |
jasiu001
reviewed
Jan 3, 2020
| } | ||
|
|
||
| err = c.Watch(&source.Kind{Type: &v1beta1.ServiceBroker{}}, eventHandler, predicate.Funcs{ | ||
| CreateFunc: func(e event.CreateEvent) bool { return e.Meta.GetName() == broker.NamespacedBrokerName }, |
There was a problem hiding this comment.
why here is permanent name helm-broker and cluster is set by configuration?
There was a problem hiding this comment.
the name of the namesaces ServiceBroker is set as a constant in the code. The ClusterServiceBroker is configurable
jasiu001
approved these changes
Jan 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Related: #54