This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Addons docs configurable #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrmiskiewicz
requested review from
adamwalach,
jasiu001,
mszostok,
PK85 and
polskikiel
as code owners
piotrmiskiewicz
added
the
area/service-management
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test pre-master-helm-broker |
piotrmiskiewicz
force-pushed
the
addons-docs-configurable
branch
4 times, most recently
from
c40eaec to
e7aa7db
Compare
polskikiel
reviewed
Aug 8, 2019
| suite.createClusterAddonsConfiguration("addon1", []string{accTestRepo}, sourceHTTP) | ||
|
|
||
| // then | ||
| suite.waitForClusterAddonsConfigurationPhase("addon1", v1alpha1.AddonsConfigurationReady) |
There was a problem hiding this comment.
please add assertClusterDocsTopicListIsEmpty() check for namespaced and cluster case
There was a problem hiding this comment.
CRDs are not installed so I cannot test it
internal/controller/setup.go
Outdated
| @@ -18,6 +18,11 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/manager" | |||
| ) | |||
|
|
|||
| type docsFacade interface { | |||
There was a problem hiding this comment.
minor: you may move that interface definition to ext.go file
piotrmiskiewicz
force-pushed
the
addons-docs-configurable
branch
from
e7aa7db to
8c894f8
Compare
polskikiel
approved these changes
Aug 8, 2019
mszostok
added
the
kind/feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Related: kyma-project/kyma#5211