This repository has been archived by the owner on May 24, 2023. It is now read-only.
Usage of sap.ui.require.preload for library-preload.js >=1.54 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
petermuessig
commented
Mar 6, 2018
tasks/preload.js
Outdated
| // workaround for new modules based on sap.ui.predefine | ||
| return 'sap.ui.require.preload(' + JSON.stringify(preloadObject.modules, null, '\t') + ', "' + preloadObject.name + '");'; | ||
| }; | ||
| } else if (iMajor === 1 && iMinor >= 40 && iMinor < 54) { |
There was a problem hiding this comment.
The < minor version 54 is not really required but makes it easier to understand the check and would be safe when moving later
matz3
suggested changes
Mar 6, 2018
tasks/preload.js
Outdated
| // Build library-preload as .js file | ||
| preloadInfo.ext = ".js"; | ||
| preloadInfo.processContent = function(content, preloadObject) { | ||
| // workaround for new modules based on sap.ui.predefine |
There was a problem hiding this comment.
I would rather call this the new API, not a workaround. I also think it's not really coupled to the sap.ui.predefine format.
tasks/preload.js
Outdated
| @@ -295,7 +302,7 @@ module.exports = function (grunt) { | |||
|
|
|||
| var content = JSON.stringify(preloadObject, null, '\t'); | |||
| if (typeof preloadInfo.processContent === 'function') { | |||
| content = preloadInfo.processContent(content); | |||
| content = preloadInfo.processContent(content, preloadObject); | |||
There was a problem hiding this comment.
We should now better only pass the preloadObject in here and both implementations should do the JSON.stringify on their own.
matz3
approved these changes
Mar 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matz3 this enables to create library-preload.js files with sap.ui.require.preload for >=1.54 and will fix the issue with the current 1.54 bower releases (jQuery is not defined issues) - should fix: SAP/openui5-sample-app#28 once we adopt the bower releases.