Further parking location fix update #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensle
requested changes
Feb 21, 2024
| for alternative in trip_mode_choice_nest["alternatives"]: | ||
| if alternative["name"] == auto_nest_name: | ||
| auto_modes = alternative["alternatives"] | ||
| break |
There was a problem hiding this comment.
Suggest you throw an assert statement / runtime error here to make sure the AUTO_MODE_NEST setting exists in the trip mode choice yaml. Also, I think we want the user to be able to specify None or something to allow them to skip having any auto modes. (There may be some weird transit or walk-only models someone thinks of.)
There was a problem hiding this comment.
I looked at the configs for prototype_mtc and saw that that has a more complicated nesting structure that the code I wrote wouldn't work for. I went ahead and set it so that the user would need to specify a list in the parking location settings (along with an assertion error saying it's needed).
…es in parking location settings
aletzdy
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous fix adjusted the origin TAZ for trips following those that ended at a parking destination other than the trip destination so that the origin of the next trip was the zone where the vehicle was parked in in order to make traffic assignment more accurate, as prior to that fix vehicles were effectively teleporting from the parking location to the trip origin. However, this did not check to see if the subsequent trip was also made by auto, resulting in non-auto trips that being at the previous trip's parking location, which will have a slight impact on transit assignment. This pull request changes the code to open the trip mode choice spec, look up what the auto modes are, and only adjust the origin TAZ if the trip is made by an auto mode. It should be noted that there will still be "teleporting vehicles" if a person uses a parking location other than their destination and then goes on an atwork subtour using a non-auto mode, but that is expected to be less common and have only a minor impact on model results.
There are also a couple of additional lines so that the origin and destination TAZs reported in final_trips always match the origin and destination MAZs.