Skeleton for extendable wallet connector #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Is there a plan to also outline APIs for the dApp to communicate with the wallet too? From a naive perspective, we discuss only that a wallet could/should express a set of APIs that a dApp can use for any necessary interaction. However, a wallet may be interested in what verifiable credentials auditors have issued to that dApp which it can present to wallets. This may not be necessary to define at all but is an area I am generally interested in. |
|
Sounds like a great candidate for an extension to this spec. 😎 |
Ryun1
force-pushed
the
extendable-dapp-connector
branch
from
e841337
to
53be8ec
Compare
rhyslbw
reviewed
Feb 14, 2023
Ryun1
force-pushed
the
extendable-dapp-connector
branch
from
8ff4d31
to
2c48589
Compare
Ryun1
force-pushed
the
extendable-dapp-connector
branch
from
49b7b9c
to
02e5547
Compare
Ryun1
added a commit
that referenced
this pull request
Mar 6, 2024
Ryun1
added a commit
that referenced
this pull request
Sep 5, 2024
* Add a draft for Query Layer Standardization * added PR number to discussions Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> * Apply suggestions from code review * Expand use cases and ecosystem risks * assign CIP number 113 * accidentally promoted as CIP instead of CPS * Update CPS-0012 directory name * removing artefact HTML comment from CPS template * removing invalid YAML for formatted Discord reference * more + deeper links to Discord discussions * add feedback from workshop 1 replacing PR #1 * Update CPS-0012/README.md Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com> * fix typo Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com> * Apply suggestions from code review * add adoption barriers and open new open question * Apply suggestions from code review Fix phrasing Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com> --------- Co-authored-by: Robert Phair <rphair@cosd.com> Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> Co-authored-by: Ryan Williams <ryan.williams@intersectmbo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to create an extendable wallet connector, this avoids placing extensionality into CIP-30. This skeleton specification handles wallet-dApp connection, allowing extensions to add useful functionality.
The first and default extension to this API is CIP-30.
This is been inspired from recent CIP discussions and heavily uses design proposed by Ktorz, thus the author tag.
PR: for comments