Skip to content

Commit

Permalink
Remove local_time gem due to js issue (basecamp/local_time#113)
Browse files Browse the repository at this point in the history
  • Loading branch information
RyanJWolfe committed Jul 1, 2022
1 parent 085263c commit 92dc21d
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 6 deletions.
2 changes: 0 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,3 @@ group :test do
gem "selenium-webdriver"
gem "webdrivers"
end

gem 'local_time'
2 changes: 0 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ GEM
jbuilder (2.11.5)
actionview (>= 5.0.0)
activesupport (>= 5.0.0)
local_time (2.1.0)
loofah (2.18.0)
crass (~> 1.0.2)
nokogiri (>= 1.5.9)
Expand Down Expand Up @@ -231,7 +230,6 @@ DEPENDENCIES
image_processing (~> 1.2)
importmap-rails
jbuilder
local_time
pg (~> 1.1)
puma (~> 5.0)
rails (~> 7.0.3)
Expand Down
2 changes: 1 addition & 1 deletion app/views/posts/_post.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</p>

<p class="my-5">
Posted <%= local_time_ago(post.created_at) %>
Posted <%= time_tag post.created_at, "data-local": "time-ago" %>
</p>

<p class="my-5">
Expand Down
2 changes: 1 addition & 1 deletion config/importmap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
pin_all_from "app/javascript/controllers", under: "controllers"
pin "trix"
pin "@rails/actiontext", to: "actiontext.js"
pin "local-time", to: "https://ga.jspm.io/npm:local-time@2.1.0/app/assets/javascripts/local-time.js"
pin "local-time" # @2.1.0
2 changes: 2 additions & 0 deletions vendor/javascript/local-time.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 92dc21d

Please sign in to comment.