Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghc 9.11 build. #63

Conversation

wavewave
Copy link
Contributor

@wavewave wavewave commented May 13, 2024

This fixes the following build error with GHC 9.11.20240512.

[49 of 67] Compiling TextShow.GHC.RTS.Flags ( src/TextShow/GHC/RTS/Flags.hs, /Users/ianwookim/repo/mercury/mwb-on-ghcHEAD/20240506/mwb-20240506/dist-newstyle/build/aarch64-osx/ghc-9.11.20240512/text-show-3.10.5/noopt/build/TextShow/GHC/RTS/Flags.dyn_o )
src/TextShow/GHC/RTS/Flags.hs:53:2: error: [GHC-39999]
    • No instance for ‘TextShow.Classes.TextShow IoManagerFlag’
        arising from a use of ‘TextShow.Classes.showbPrec’
    • In the first argument of ‘(<>)’, namely
        ‘TextShow.Classes.showbPrec 0 arg11_a1iZs’
      In the second argument of ‘(<>)’, namely
        ‘(TextShow.Classes.showbPrec 0 arg11_a1iZs
            <>
              (TextShow.Classes.showbCommaSpace
                 <>
                   (Data.Text.Internal.Builder.fromString "numIoWorkerThreads = "
                      <>
                        (TextShow.Classes.showbPrec 0 arg12_a1iZt
                           <> Data.Text.Internal.Builder.singleton '}'))))’
      In the second argument of ‘(<>)’, namely
        ‘(Data.Text.Internal.Builder.fromString "ioManager = "
            <>
              (TextShow.Classes.showbPrec 0 arg11_a1iZs
                 <>
                   (TextShow.Classes.showbCommaSpace
                      <>
                        (Data.Text.Internal.Builder.fromString "numIoWorkerThreads = "
                           <>
                             (TextShow.Classes.showbPrec 0 arg12_a1iZt
                                <> Data.Text.Internal.Builder.singleton '}')))))’
   |
53 | $(deriveTextShow ''MiscFlags)
   |  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Could you add this here or to head.hackage patch list, (as you prefer)? Thanks!

@wavewave wavewave force-pushed the wavewave/ghcHEAD-20240506 branch from 9200723 to d148601 Compare May 13, 2024 21:03
@wavewave wavewave force-pushed the wavewave/ghcHEAD-20240506 branch from d148601 to ea43f6d Compare May 13, 2024 21:10
@wavewave wavewave changed the title Fix ghc 9.10.20240512 build. Fix ghc 9.11 build. May 13, 2024
@RyanGlScott
Copy link
Owner

Thanks for the patch.

Given that this is targeting a pre-release version of GHC (and one that likely won't be released for quite a while), I'm somewhat reluctant to merge this in just yet. If it's alright with you, I'd prefer to add this to head.hackage for now as a stopgap measure.

@RyanGlScott
Copy link
Owner

I've submitted https://gitlab.haskell.org/ghc/head.hackage/-/merge_requests/369 to add this patch to head.hackage.

RyanGlScott added a commit that referenced this pull request Oct 22, 2024
This adds a `TextShow` for `IoManagerFlag` in `TextShow.GHC.RTS.Flags`. This
also adds support for `IoManagerFlag` in the test suite.

This patch is heavily inspired by Ian-Woo Kim's earlier work in #63, as well as
the corresponding `head.hackage` patch in
https://gitlab.haskell.org/ghc/head.hackage/-/merge_requests/369.

Supersedes #63.

Co-authored-by: Ian-Woo Kim <ianwookim@gmail.com>
RyanGlScott added a commit that referenced this pull request Oct 23, 2024
This adds a `TextShow` for `IoManagerFlag` in `TextShow.GHC.RTS.Flags`. This
also adds support for `IoManagerFlag` in the test suite.

This patch is heavily inspired by Ian-Woo Kim's earlier work in #63, as well as
the corresponding `head.hackage` patch in
https://gitlab.haskell.org/ghc/head.hackage/-/merge_requests/369.

Supersedes #63.

Co-authored-by: Ian-Woo Kim <ianwookim@gmail.com>
@RyanGlScott
Copy link
Owner

Superseded by #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants