Allow work factories with other return types than Observable
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for the PR, I'll try to take a look this afternoon. |
ashfurrow
approved these changes
Nov 16, 2017
Sources/Action/Action.swift
Outdated
| @@ -4,6 +4,8 @@ import RxCocoa | |||
|
|
|||
| /// Typealias for compatibility with UIButton's rx.action property. | |||
| public typealias CocoaAction = Action<Void, Void> | |||
| /// Typealias for actions with work factory returns `Completable` | |||
There was a problem hiding this comment.
Can we add a . at the end for consistency?
mosamer
force-pushed
the
primitive-sequence-init
branch
from
65bf3bf to
f90e164
Compare
|
I applied the required updates. As a side note, I see that CI was never triggered! |
|
Oops! We recently changed CI providers and I hadn't yet configured Circle to build on PRs from forks. It should work going forward. Thanks for pointing that out! |
ashfurrow
approved these changes
Nov 20, 2017
|
@ashfurrow A point release will be super! should I update pod spec? or will you take care of that? |
|
No worries – I've got it pushed as 3.5.0, let me know if there are any issues 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #123
ObservableConvertibleType. This allows constructing Actions with work factory returning;PrimitiveSequencesuch asSingle,Completable, etc.SharedSequencesuch asDriverCompletableAction.Completableelementswill emit no next events