Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rc-0
shareReplay(1)
to use the new APIshare(replay: 1, scope: .forever)
RxSwift ShareSubject
Mortred
release ofRxSwift
completely changed it's behavior. With the introduction ofSubjectLifetimeScope
enum. The default is to use.share(replay: 1, scope: .whileConnected)
or.share(replay: 1)
which means the same thing. The above mentioned behavior see that When the number of subscribers drops from 1 to 0 and connection to source sequence is disposed, subject will be cleared.In
Action
sticked to the old behavior.shareReplay(1)
which is represented in the new api as follows.share(replay: 1, scope: .forever)
This behavior see that after number of subscribers drops from 1 to 0 and connection to source observable sequence is disposed, this operator will continue holding a reference to the same subject. So the talking point here is that onAction.elements
after source sequence terminates any new observer will always immediatelly receive replayed elements