Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxSwift 4.0.0-rc0 #110

Merged
merged 1 commit into from
Oct 12, 2017
Merged

RxSwift 4.0.0-rc0 #110

merged 1 commit into from
Oct 12, 2017

Conversation

bobgodwinx
Copy link
Member

@bobgodwinx bobgodwinx commented Oct 12, 2017

  • Updates for RxSwift release candidate rc-0
  • change shareReplay(1) to use the new API share(replay: 1, scope: .forever)

RxSwift ShareSubject

  • The Mortred release of RxSwift completely changed it's behavior. With the introduction of SubjectLifetimeScope enum. The default is to use .share(replay: 1, scope: .whileConnected) or .share(replay: 1) which means the same thing. The above mentioned behavior see that When the number of subscribers drops from 1 to 0 and connection to source sequence is disposed, subject will be cleared.
    In Action sticked to the old behavior .shareReplay(1) which is represented in the new api as follows .share(replay: 1, scope: .forever) This behavior see that after number of subscribers drops from 1 to 0 and connection to source observable sequence is disposed, this operator will continue holding a reference to the same subject. So the talking point here is that on Action.elements after source sequence terminates any new observer will always immediatelly receive replayed elements

Updates for RxSwift release candidate `rc-0`
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@ashfurrow ashfurrow merged commit ee52caf into RxSwiftCommunity:master Oct 12, 2017
@ashfurrow
Copy link
Member

Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.

@bobgodwinx
Copy link
Member Author

Thanks for the warm welcome it's always a pleasure to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants