signature: use &mut impl CryptoRngCore RNG arguments
#1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rand_core` v0.6.4 added an auto-impl'd `CryptoRngCore` marker trait for types which impl `CryptoRng + RngCore` which is slightly more convenient and less verbose. This commit changes to using `&mut impl CryptoRngCore` as proposed in #1087. This hopefully strikes a balance between least surprise and minimal required syntax, namely &mut references are reusable and don't require knowledge of the blanket impl of `RngCore` for `&mut R: RngCore`
|
I opened #1148 which spells out the rationale for this type signature a bit more and can hopefully serve as a place to discuss if we should switch to this across the other trait crates (or if not this, then discussing what it should be). |
tarcieri
added a commit
that referenced
this pull request
Nov 4, 2022
In #1147, other usages of a CSRNG were changed to use `&mut impl CryptoRngCore`. However, `RandomizedPrehashSigner` was not updated accordingly. This commit updates it as well.
tarcieri
added a commit
that referenced
this pull request
Nov 4, 2022
In #1147, other usages of a CSRNG were changed to use `&mut impl CryptoRngCore`. However, `RandomizedPrehashSigner` was not updated accordingly. This commit updates it as well.
tarcieri
added a commit
that referenced
this pull request
Nov 4, 2022
In #1147, other usages of a CSRNG were changed to use `&mut impl CryptoRngCore`. However, `RandomizedPrehashSigner` was not updated accordingly. This commit updates it as well.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Nov 4, 2022
As discussed in RustCrypto/traits#1148, this uses `&mut impl CryptoRngCore` as the API for passing CSRNGs. This removes the need for a generic parameter in the type signature while also keeping syntax to a minimum. The traits in `signature` v2.0.0-pre.2 switched to these APIs. See RustCrypto/traits#1147.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Nov 4, 2022
As discussed in RustCrypto/traits#1148, this uses `&mut impl CryptoRngCore` as the API for passing CSRNGs. This removes the need for a generic parameter in the type signature while also keeping syntax to a minimum. The traits in `signature` v2.0.0-pre.2 switched to these APIs. See RustCrypto/traits#1147.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand_corev0.6.4 added an auto-impl'dCryptoRngCoremarker trait for types which implCryptoRng + RngCorewhich is slightly more convenient and less verbose.This commit changes to using
&mut impl CryptoRngCoreas proposed in #1087. This hopefully strikes a balance between least surprise and minimal required syntax, namely &mut references are reusable and don'trequire knowledge of the blanket impl of
RngCorefor&mut R: RngCore